change the logic of show more from number of lines to number characters #9452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timolegros
reviewed
Oct 4, 2024
| @@ -209,7 +209,7 @@ export const ThreadCard = ({ | |||
| <CWText type="b1" className="content-body"> | |||
| <QuillRenderer | |||
| doc={bodyText} | |||
| cutoffLines={4} | |||
| maxChars={500} | |||
There was a problem hiding this comment.
Can we maybe put this as a constant in shared/src/constants.ts? It is a useful reference for me on the backend where we will soon be truncating all bodies longer than the amount required for previews.
There was a problem hiding this comment.
sure , i will put there .
"I noticed that we're using in different places, and in some instances, we're setting cutoffLines to 50 or 10. Should I replace all occurrences of cutoffLines with maxchars, or should we keep support for cutoffLines so that it continues to work as it currently does in other places?"
@Israellund
There was a problem hiding this comment.
@KaleemNeslit I think this is a good question for @mzparacha What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Issue
Closes: #9276
Description of Changes