Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: ๐Ÿ‘ Carousel UI infinite scroll ๊ตฌํ˜„ #139

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[FEAT]: ๐Ÿ‘ Carousel UI infinite scroll ๊ตฌํ˜„ #139

wants to merge 5 commits into from

Conversation

hidaehyunlee
Copy link
Owner

@hidaehyunlee hidaehyunlee commented Nov 10, 2023 •
edited
Loading

DetailView UI ์ˆ˜์ •

commit์€ ์ด๊ฑฐ ๋‘๊ฐœ๋งŒ ๋ณด๋ฉด ๋˜์„ธ์š”. detial ์ปค๋ฐ‹์ด๋ž‘ ํ•ฉ์ณ์ ธ์„œ ..

  • [FEAT]: ๐Ÿ‘ add infiniteScroll logic

  • [FIX]: ๐Ÿ› delete goToFirstButton

  • ๋งจ ์ฒ˜์Œ์œผ๋กœ ๋ฒ„ํŠผ์„ ์—†์• ๊ณ  ๋ฌดํ•œ ์Šคํฌ๋กค ๋ฐฉ์‹์œผ๋กœ ๊ฐ์“ฐ๋ฅผ ๋ณผ ์ˆ˜ ์žˆ๋„๋ก ํ•ด๋ดค์Šต๋‹ˆ๋‹ค.

  • ์ด์œ ๋Š” ... ๋งจ ์ฒ˜์Œ์œผ๋กœ ๋ฒ„ํŠผ ๊ตฌํ˜„ํ•  ๋•Œ ์—๋Ÿฌ๊ฐ€ ๋งŽ์•„์„œ ...

  • ์œ— ๊ณต๊ฐ„์— ์ž๋ฆฌ๊ฐ€ ๋งŽ์ด ๋‚จ๋Š”๋ฐ ๋ผ์ดํƒ€์ดํ‹€ ๋“ฑ์œผ๋กœ ๊ฐ์ •์“ฐ๋ ˆ๊ธฐํ†ต ์ด๋Ÿฐ ํƒ€์ดํ‹€์„ ๋‹ฌ๋ฉด ์–ด๋–จ๊นŒ์š” ?

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-10.at.14.27.26.mp4

@hidaehyunlee hidaehyunlee self-assigned this Nov 10, 2023
@anfgbwl
Copy link
Collaborator

anfgbwl commented Nov 10, 2023

๊ทผ๋ฐ ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ๊ฒŒ์‹œ๊ธ€์ด ๋งŽ์„ ๋•Œ ๋ญ”๊ฐ€ ์‚ดํŽด๋ณด๊ธฐ ํž˜๋“ค๊ฑฐ๊ฐ™๊ธด ํ•ด์š”ใ…œ

@hidaehyunlee
Copy link
Owner Author

๊ฒƒ๋‘ ๋งž๊ธด ํ•ด์š” .. ใ…œ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doyuny doyuny doyuny approved these changes

@june-hehe june-hehe june-hehe approved these changes

@anfgbwl anfgbwl Awaiting requested review from anfgbwl

Assignees

@hidaehyunlee hidaehyunlee

Labels
UI ์ˆ˜์ •
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hidaehyunlee @anfgbwl @doyuny @june-hehe