Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix article sharing #1003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WillieCubed
Copy link

Fixes #917, #930, #985 by using a proper share picker.

- Use intent picker instead of default app
@pretzelwagon
Copy link

Does this fix work? Why hasn't it been merged? Such a painful bug, as I use sharing all the time; causing me to consider leaving to another reader.

@tamsky
Copy link

tamsky commented Mar 10, 2018

test failures simply need to be updated to change the expected result to follow this change...

    java.lang.AssertionError: Expected action <android.intent.action.SEND> but was
<android.intent.action.CHOOSER>.

@hidroh
Copy link
Owner

hidroh commented Mar 10, 2018

Hey all sorry for late reply, let me review this. I think I have been going back and forth on this chooser vs non chooser a few times. If I remember correctly the chooser doesn't offer the options Just once/Always, and people complain about that, while non-chooser (relying on platform chooser) has different behavior on Samsung devices.

@garymoon
Copy link

Thank you so much for this @WillieCubed! I recently had need to make an adjustment to another OSS app I use, and thought I'd try to tackle the share menu in Materialistic while I was at it (it's the only app I use with the old-style share menu so I miss out on direct share and pinned apps). Thanks to you the process took me 10 minutes from start to finish.

@hidroh Thank you of course for Materialistic! If you want to consider merging this PR I'm happy to help with testing or whatever else a non-android-dev might be useful for. I have access to a OnePlus 3t running Lineage and a OnePlus 5 running stock Oxygen.

Thanks again guys!

@WillieCubed
Copy link
Author

Bump for @hidroh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please turn of the default sharing method!
5 participants