Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for PublishBlockStream to simulator #548

Merged

Conversation

georgi-l95
Copy link
Member

Description:
This PR adds support for PublishBlockStream in the simulator, by introducing new wokring mode, called PublisherServerMode, where the application acts a server, which listents and awaits stream of block data. With the effort here I aim mainly to introduce the feature, where in future ones we will refine it, according to needs to be able to use it as testing driver.

Related issue(s):

Fixes #430

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
@georgi-l95 georgi-l95 added the Simulator Issue related to Block Stream Simulator label Jan 28, 2025
@georgi-l95 georgi-l95 added this to the 0.4.0 milestone Jan 28, 2025
@georgi-l95 georgi-l95 self-assigned this Jan 28, 2025
@georgi-l95 georgi-l95 linked an issue Jan 28, 2025 that may be closed by this pull request
@georgi-l95 georgi-l95 marked this pull request as ready for review January 28, 2025 13:54
@georgi-l95 georgi-l95 requested a review from a team as a code owner January 28, 2025 13:54
Copy link
Contributor

@ata-nas ata-nas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice Job!

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@georgi-l95 georgi-l95 merged commit e1d3826 into main Feb 5, 2025
25 checks passed
@georgi-l95 georgi-l95 deleted the 430-add-support-for-publishblockstream-to-simulator branch February 5, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simulator Issue related to Block Stream Simulator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PublishBlockStream to simulator
3 participants