Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Unify HandleException and PreCheckException #17736

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

MiroslavGatsanoga
Copy link
Contributor

@MiroslavGatsanoga MiroslavGatsanoga commented Feb 6, 2025

Description:

Related issue(s):

Fixes #13688

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@MiroslavGatsanoga MiroslavGatsanoga added this to the v0.60 milestone Feb 6, 2025
@MiroslavGatsanoga MiroslavGatsanoga self-assigned this Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 65.59356% with 171 lines in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (243d47f) to head (fee0022).

Files with missing lines Patch % Lines
.../app/workflows/prehandle/PreHandleContextImpl.java 33.33% 10 Missing ⚠️
...rvice/token/impl/handlers/CryptoCreateHandler.java 55.00% 4 Missing and 5 partials ⚠️
.../hedera/node/app/workflows/TransactionChecker.java 72.00% 7 Missing ⚠️
...ervice/token/impl/handlers/TokenRejectHandler.java 25.00% 2 Missing and 4 partials ⚠️
...ract/impl/handlers/EthereumTransactionHandler.java 37.50% 2 Missing and 3 partials ⚠️
...oken/impl/util/CryptoTransferValidationHelper.java 0.00% 5 Missing ⚠️
...pp/workflows/dispatcher/TransactionDispatcher.java 0.00% 4 Missing ⚠️
...rkflows/handle/validation/ExpiryValidatorImpl.java 33.33% 4 Missing ⚠️
...sus/impl/handlers/ConsensusUpdateTopicHandler.java 33.33% 4 Missing ⚠️
...contracts/common/AbstractNativeSystemContract.java 0.00% 4 Missing ⚠️
... and 68 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17736   +/-   ##
=========================================
  Coverage     68.95%   68.95%           
+ Complexity    22979    22973    -6     
=========================================
  Files          2646     2645    -1     
  Lines         99405    99375   -30     
  Branches      10284    10284           
=========================================
- Hits          68542    68525   -17     
+ Misses        26972    26960   -12     
+ Partials       3891     3890    -1     
Files with missing lines Coverage Δ
...e/addressbook/impl/handlers/NodeCreateHandler.java 98.11% <100.00%> (ø)
...ode/app/service/addressbook/AddressBookHelper.java 93.93% <ø> (ø)
...ra/node/app/spi/validation/AttributeValidator.java 100.00% <ø> (ø)
...edera/node/app/spi/validation/ExpiryValidator.java 100.00% <ø> (ø)
...om/hedera/node/app/spi/validation/Validations.java 96.00% <100.00%> (ø)
...m/hedera/node/app/spi/workflows/HandleContext.java 82.35% <ø> (ø)
...pp/spi/workflows/InsufficientBalanceException.java 100.00% <ø> (ø)
...edera/node/app/spi/workflows/PreHandleContext.java 0.00% <ø> (ø)
...om/hedera/node/app/spi/workflows/QueryHandler.java 0.00% <ø> (ø)
.../app/spi/workflows/ResourceExhaustedException.java 100.00% <ø> (ø)
... and 174 more

... and 2 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 73.40%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (243d47f) 99188 72282 72.87%
Head commit (fee0022) 99158 (-30) 72264 (-18) 72.88% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17736) 500 367 73.40%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify HandleException and PreCheckException
1 participant