feat: Add support for consensus time period in blocks (#17536) #17920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ts/src/main/java/com/hedera/services/bdd/spec/utilops/pauses/HapiSpecWaitUntilNextBlock.java
Show resolved
Hide resolved
...ts/src/main/java/com/hedera/services/bdd/spec/utilops/pauses/HapiSpecWaitUntilNextBlock.java
Show resolved
Hide resolved
Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: Derek Riley <[email protected]>
Signed-off-by: Derek Riley <[email protected]>
derektriley
force-pushed
the
17469-consensus-time-perid-blocks-2
branch
from
f278b14 to
9c5f13a
Compare
Signed-off-by: Derek Riley <[email protected]>
mhess-swl
approved these changes
Feb 20, 2025
...test-clients/src/main/java/com/hedera/services/bdd/suites/contract/records/RecordsSuite.java
Show resolved
Hide resolved
Neeharika-Sompalli
approved these changes
Feb 20, 2025
petreze
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, blocks are created based on a fixed number of rounds per block (default 1). This PR adds support for creating blocks based on a configurable period of consensus time. In addition, a marker file is written to disk when each block file is considered closed.
General:
BlockStreamConfig: updated to have configurable consensus time period for blocks
@ConfigProperty(defaultValue = "2") @Min(0) @NetworkProperty int blockPeriodHedera.java: Replaced BiConsumer with BiPredicate for onSealConsensusRound. Updated the manageBlockEndRound method to return a boolean.
Added new HapiSpecWaitUntilNextBlock in test-clients to reliably wait until the next block is written to disk. This fixes issues in some test cases which want to wait until the next block.
Miscellaneous Changes:
FileBlockItemWriter.java: Modified to write a marker file when closing a block to indicate completion.
Updated tests which simulate post upgrade boundary to wait until genesis block is closed as classifying pending work is performed at the beginning of a block.
Related issue(s):
Fixes #17469
Notes for reviewer:
Checklist