Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust documentation #2181

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

naydenovn
Copy link
Contributor

Description:
Adjusting java documentation where necessary. Documentation is inspired by protobufs and tests

Related issue(s):

Fixes #
#2120
Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@naydenovn naydenovn requested a review from a team as a code owner January 17, 2025 08:17
@naydenovn naydenovn requested a review from agadzhalov January 17, 2025 08:17
@naydenovn naydenovn self-assigned this Jan 17, 2025
@naydenovn naydenovn requested a review from 0xivanov January 17, 2025 08:17
Signed-off-by: Naydenov <[email protected]>
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.69%. Comparing base (b86ee46) to head (9aac194).
Report is 225 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2181      +/-   ##
============================================
- Coverage     82.20%   78.69%   -3.51%     
- Complexity     3588     4094     +506     
============================================
  Files           186      243      +57     
  Lines         11697    13740    +2043     
  Branches       1150     1335     +185     
============================================
+ Hits           9615    10813    +1198     
- Misses         1604     2454     +850     
+ Partials        478      473       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov requested a review from a team as a code owner February 13, 2025 10:48
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...hgraph/sdk/AccountAllowanceApproveTransaction.java 84.92% <ø> (ø) 36.00 <0.00> (?)
...shgraph/sdk/AccountAllowanceDeleteTransaction.java 79.68% <ø> (ø) 14.00 <0.00> (?)
...hedera/hashgraph/sdk/AccountCreateTransaction.java 93.79% <ø> (ø) 43.00 <0.00> (?)
...hedera/hashgraph/sdk/AccountDeleteTransaction.java 78.04% <ø> (ø) 11.00 <0.00> (?)
...hedera/hashgraph/sdk/AccountUpdateTransaction.java 68.87% <ø> (ø) 35.00 <0.00> (?)
...edera/hashgraph/sdk/ContractCreateTransaction.java 85.25% <ø> (ø) 43.00 <0.00> (?)
...edera/hashgraph/sdk/ContractDeleteTransaction.java 73.58% <ø> (ø) 13.00 <0.00> (?)
...dera/hashgraph/sdk/ContractExecuteTransaction.java 83.63% <ø> (ø) 13.00 <0.00> (?)
...edera/hashgraph/sdk/ContractUpdateTransaction.java 67.51% <ø> (ø) 35.00 <0.00> (?)
.../com/hedera/hashgraph/sdk/EthereumTransaction.java 77.27% <ø> (ø) 9.00 <0.00> (?)
... and 36 more

Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 8465ed0 into main Feb 13, 2025
8 checks passed
@0xivanov 0xivanov deleted the 2120-add-missing-JavaDoc-commetns branch February 13, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants