Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce new AccountAllowance endpoints #2222

Merged
merged 5 commits into from
Feb 14, 2025
Merged

feat: introduce new AccountAllowance endpoints #2222

merged 5 commits into from
Feb 14, 2025

Conversation

naydenovn
Copy link
Contributor

fixes:
#2184

@naydenovn naydenovn self-assigned this Feb 11, 2025
@naydenovn naydenovn requested a review from a team as a code owner February 11, 2025 13:31
@naydenovn
fix: fix build
b6cc136 
Signed-off-by: Naydenov <[email protected]>
@naydenovn naydenovn requested review from a team as code owners February 11, 2025 14:35
mishomihov00
mishomihov00 previously approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/build.yml

@naydenovn
fix: fix import
0e6fb5a 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: fix build
73bc242 
Signed-off-by: Naydenov <[email protected]>
@naydenovn
fix: resolve PR comment
22fa4a3 
Signed-off-by: Naydenov <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...dera/hashgraph/tck/methods/sdk/AccountService.java 0.00% 47 Missing ⚠️
...tck/methods/sdk/param/account/AllowanceParams.java 0.00% 36 Missing ⚠️
...hods/sdk/param/account/AccountAllowanceParams.java 0.00% 3 Missing ⚠️
.../hedera/hashgraph/tck/util/JSONRPCParamParser.java 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ Complexity Δ
...hgraph/sdk/AccountAllowanceApproveTransaction.java 87.70% <ø> (ø) 36.00 <0.00> (?)
.../hedera/hashgraph/tck/util/JSONRPCParamParser.java 29.41% <0.00%> (ø) 3.00 <0.00> (?)
...hods/sdk/param/account/AccountAllowanceParams.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tck/methods/sdk/param/account/AllowanceParams.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...dera/hashgraph/tck/methods/sdk/AccountService.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)

0xivanov
0xivanov approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit a7e4136 into main Feb 14, 2025
8 checks passed
@0xivanov 0xivanov deleted the 2184-account-allowance-transaction-endpoint branch February 14, 2025 10:34
@0xivanov 0xivanov mentioned this pull request Feb 17, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjohannes jjohannes jjohannes left review comments

@0xivanov 0xivanov 0xivanov approved these changes

@mishomihov00 mishomihov00 mishomihov00 left review comments

Assignees

@naydenovn naydenovn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naydenovn @jjohannes @0xivanov @mishomihov00