-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenAPI integrated for mirror node models generation #329
base: main
Are you sure you want to change the base?
Conversation
…d allies Signed-off-by: ivaylogarnev-limechain <[email protected]>
Signed-off-by: ivaylogarnev-limechain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should place instructions for generating these models somewhere in the README somewhere? Might be useful for anyone to know.
Also, is it common practice to name a directory with a .ts
extension?
…roduced Taskfile Signed-off-by: ivaylogarnev-limechain <[email protected]>
Yes, absolutely! I initially thought we were generating these models just for our own use, but you’re right—it’s important for everyone to be aware of the process. To address this, I’ve added a detailed section to the README explaining OpenAPI model generation. Additionally, I had previously handled the post-generation cleanup manually, but I’ve now introduced a Taskfile to automate the process. As for the |
Signed-off-by: ivaylogarnev-limechain <[email protected]>
b2e48bd
to
de6cf66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last fix and then I think we're good to go. Thanks for integrating this, this is awesome!
@@ -13,7 +13,7 @@ import { | |||
/** | |||
* Tests for TokenMintTransaction | |||
*/ | |||
describe("TokenMintTransaction", function () { | |||
describe.only("TokenMintTransaction", function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe.only("TokenMintTransaction", function () { | |
describe("TokenMintTransaction", function () { |
Description:
This PR integrates
OpenAPI
for generating Mirror Node models and incorporates their usage in the code where applicable. It also adds aliases for importing these models and includes various refactors.Related issue(s):
#276
Checklist