Merge pull request #22 from highcharts-for-python/develop

PR for v.1.1.1
highcharts-for-python · Apr 27, 2023 · 6c3210f · 6c3210f
2 parents b70d277 + 7e958b3
commit 6c3210f
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,3 +1,11 @@
+Release 1.1.1
+=========================================
+
+* **FIXED:** Problem when producing a JS literal, with the JS code inserting an unnecessary ``new``.
+* **ENHANCEMENT:** Added more elegant error handling when something goes wrong displaying a chart in Jupyter.
+
+---------------------
+
 Release 1.1.0
 =========================================
 

diff --git a/highcharts_gantt/__version__.py b/highcharts_gantt/__version__.py
@@ -1 +1 @@
-__version__ = '1.1.0'
+__version__ = '1.1.1'
diff --git a/highcharts_gantt/chart.py b/highcharts_gantt/chart.py
@@ -281,11 +281,11 @@ def to_js_literal(self,
             callback_as_str = f"""{callback_as_str}"""
             signature_elements += 1
 
-        signature = """new Highcharts.chart("""
+        signature = """Highcharts.chart("""
         if self.is_gantt_chart:
-            signature = """new Highcharts.ganttChart("""
+            signature = """Highcharts.ganttChart("""
         elif self.is_stock_chart:
-            signature = """new Highcharts.stockChart("""
+            signature = """Highcharts.stockChart("""
         if container_as_str:
             signature += container_as_str
             if signature_elements > 1:

diff --git a/tests/input_files/chart_obj/01-expected.js b/tests/input_files/chart_obj/01-expected.js
@@ -1,4 +1,4 @@
-var someVariableName = new Highcharts.stockChart('some-div-id',
+var someVariableName = Highcharts.stockChart('some-div-id',
 {
   accessibility: {
       announceNewData: {