Handle invalid holdings

highcharts · Sep 20, 2024 · cdef3ec · cdef3ec
1 parent 0edb11b
commit cdef3ec
Showing 1 changed file with 20 additions and 0 deletions.
diff --git a/src/RiskScore/RiskScoreConverter.ts b/src/RiskScore/RiskScoreConverter.ts
@@ -124,6 +124,7 @@ export class RiskScoreConverter extends MorningstarConverter {
         // Parse and cumulate risk scores by date
 
         const sortedPortfolios: RiskScorePortfolio[] = [];
+        const errors: string[] = [];
 
         for (const riskScorePortfolio of json.riskScores) {
             const {
@@ -147,6 +148,21 @@ export class RiskScoreConverter extends MorningstarConverter {
                 retainedWeightProxied,
                 scoringMethodUsed
             });
+
+            if (
+                riskScorePortfolio.metadata !== undefined && 
+                riskScorePortfolio.metadata.messages.length > 0
+            ) {
+                for (const message of riskScorePortfolio.metadata.messages) {
+                    const holdingNames = message.invalidHoldings.map(
+                        invalidHolding => invalidHolding.identifier
+                    );
+
+                    errors.push(
+                        `The holding(s) ${holdingNames.join(', ')} are invalid. ${message.message}`
+                    );
+                }
+            }
         }
 
         sortedPortfolios.sort((a, b) => (
@@ -196,6 +212,10 @@ export class RiskScoreConverter extends MorningstarConverter {
             }
         }
 
+        if (errors.length > 0) {
+            throw new Error(errors.join('\n'));
+        }
+
         return true;
     }