Skip to content

Commit

Permalink
Changed “value” to “volume” in OHLCV (#27).
Browse files Browse the repository at this point in the history
  • Loading branch information
Eskils authored Aug 30, 2024
1 parent 3202f0c commit de782d1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/connectors/morningstar/time-series/ohlcv.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This type yields OHLCV time series data for a single or multiple securities.

Returns Open, High, Low, Close, Value for the securities specified.
Returns Open, High, Low, Close, Volume for the securities specified.

> **NOTE:** At the moment only a single security is supported.
Expand Down
4 changes: 2 additions & 2 deletions src/TimeSeries/Converters/OHLCVSeriesConverter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import MorningstarURL from '../../Shared/MorningstarURL';
interface OHLCV {
Id: string;
Date: number;
Value: [open: number, high: number, low: number, close: number, value: number];
Value: [open: number, high: number, low: number, close: number, volume: number];
}


Expand Down Expand Up @@ -127,7 +127,7 @@ export class OHLCVSeriesConverter extends TimeSeriesConverter {

table.deleteColumns();

const valueColumns = ['Open', 'High', 'Low', 'Close', 'Value'];
const valueColumns = ['Open', 'High', 'Low', 'Close', 'Volume'];

table.setColumn('Date');

Expand Down
2 changes: 1 addition & 1 deletion src/TimeSeries/TimeSeriesJSON.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ namespace TimeSeriesJSON {
high: number,
low: number,
close: number,
value: number
volume: number
];


Expand Down
2 changes: 1 addition & 1 deletion test/unit-tests/TimeSeries/OHLCV.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export async function ohlcvLoad (
`${securityId}_High`,
`${securityId}_Low`,
`${securityId}_Close`,
`${securityId}_Value`
`${securityId}_Volume`
],
'Connector table should exist of expected columns.'
);
Expand Down

0 comments on commit de782d1

Please sign in to comment.