Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved RNANews demo #13

Merged
merged 7 commits into from
Aug 19, 2024
Merged

Improved RNANews demo #13

merged 7 commits into from
Aug 19, 2024

Conversation

Eskils
Copy link
Contributor

@Eskils Eskils commented Aug 16, 2024 •
edited
Loading

MSRNANewsDemoNewImpl.mp4
  • Fixed data validation for RNANews
  • Make demo work with morningstar-standalone
  • Apply styling
  • Add select for Postman environment file

@Eskils Eskils changed the base branch from main to bug/fix-forbidden-response-in-demo August 16, 2024 13:38
@Eskils Eskils requested a review from bre1470 August 16, 2024 14:44
@Eskils Eskils marked this pull request as ready for review August 16, 2024 14:44
@Eskils Eskils self-assigned this Aug 16, 2024
Base automatically changed from bug/fix-forbidden-response-in-demo to main August 16, 2024 15:57
bre1470
bre1470 requested changes Aug 16, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs merge from main to remove outdated API code.

@Eskils Eskils requested a review from bre1470 August 19, 2024 07:29
@Eskils
[Feature] Add unit test for RNANews (#14)
ac39f8c 
* Implement test for loading RNANews
* Implement test for RNANews response validation
bre1470
bre1470 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawless. 👍

@bre1470 bre1470 merged commit 12498c5 into main Aug 19, 2024
3 checks passed
@bre1470 bre1470 deleted the feature/improve-rna-news-demo branch August 19, 2024 07:57
@bre1470 bre1470 changed the title [Feature] Improve RNANews demo Improved RNANews demo Aug 30, 2024
@bre1470 bre1470 added this to the v0.2.0 milestone Aug 30, 2024
@bre1470 bre1470 added the documentation Improvements or additions to documentation label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bre1470 bre1470 bre1470 approved these changes

Assignees

@Eskils Eskils

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskils @bre1470