Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PriceSeriesConverter #17

Merged
merged 13 commits into from
Aug 20, 2024
Merged

Added PriceSeriesConverter #17

merged 13 commits into from
Aug 20, 2024

Conversation

Eskils
Copy link
Contributor

@Eskils Eskils commented Aug 19, 2024 •
edited
Loading

This PR aims to implement support for price series.

Notes

Price has an additional api parameter priceType which I chose to put in PriceSeriesOptions. This parameter is set in the URLSearchParams through the new additionalConnectorOptions in TimeSeriesConenctor.

@Eskils Eskils requested a review from bre1470 August 19, 2024 09:25
bre1470
bre1470 requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but this is a bit messy in the connector, when the option is related to the converter option. See refactor comments.

src/TimeSeries/TimeSeriesConnector.ts Outdated Show resolved Hide resolved
src/TimeSeries/TimeSeriesConnector.ts Outdated Show resolved Hide resolved
@Eskils Eskils requested a review from bre1470 August 19, 2024 11:18
@Eskils Eskils self-assigned this Aug 19, 2024
bre1470
bre1470 requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Two things:
TimeSeriesConverter should go up one folder to avoid confusion with implementations. src/TimeSeries/index should export TimeSeriesConverter in case of user extensions.

@Eskils Eskils requested a review from bre1470 August 19, 2024 11:56
bre1470
bre1470 reviewed Aug 19, 2024
View reviewed changes
src/TimeSeries/index.ts Outdated Show resolved Hide resolved
@Eskils Eskils requested a review from bre1470 August 20, 2024 07:15
bre1470
bre1470 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍

@bre1470 bre1470 merged commit 7e9eb15 into main Aug 20, 2024
3 checks passed
@bre1470 bre1470 deleted the feature/implement-price-connector branch August 20, 2024 07:40
@bre1470 bre1470 changed the title [Feature] Implement PriceSeriesConnector Added PriceSeriesConverter Aug 30, 2024
@bre1470 bre1470 added this to the v0.2.0 milestone Aug 30, 2024
@bre1470 bre1470 added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bre1470 bre1470 bre1470 approved these changes

Assignees

@Eskils Eskils

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskils @bre1470