Added docs for TimeSeries and RNANews connectors. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngstar into feature/add-docs
Fix idType in rna news demo
* Specify font * Fix assigning data to chart * Use area with gradient fill * Update docs to match changed demo --------- Co-authored-by: bre1470 <[email protected]>
bre1470
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Some updates are needed:
- I agree with your comment, but we should at least cross reference, so that people find the RNA news connector. You did this already, afaik. So this point is done.
- All documents should reflect the renaming from
@highcharts/morningstar-connectorsto@highcharts/connectors-morningstar. - The standalone bundle is now
connectors-morningstar.js. - Maybe link to the corresponding Morningstar API in a footnote, in case someone is interested in technical details.
bre1470
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to supply documentation for new connectors and how to use them with dashboards and Highcharts.
Considerations