Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made EMEA default in RNANews #25

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

Eskils
Copy link
Contributor

@Eskils Eskils commented Aug 29, 2024

Motivation

Since Regulatory News Announcements are only available in Great Britain, the EMEA server is the only one that supports this endpoint. It therefore makes sense for this to be the default regardless of the region the user is in.

@Eskils Eskils requested a review from bre1470 August 29, 2024 13:05
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpicking, otherwise good to merge! 👍

src/RNANews/RNANewsConnector.ts Outdated Show resolved Hide resolved
@bre1470 bre1470 merged commit 065ea16 into main Aug 30, 2024
3 checks passed
@bre1470 bre1470 deleted the feature/make-emea-default-in-rna-news branch August 30, 2024 10:47
@bre1470 bre1470 changed the title [Feature] Make EMEA default in RNANews Made EMEA default in RNANews Aug 30, 2024
@bre1470 bre1470 added this to the Next milestone Aug 30, 2024
@bre1470 bre1470 added the bugfix Something isn't working label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants