Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added X-Ray Connector. #29

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Added X-Ray Connector. #29

merged 16 commits into from
Sep 17, 2024

Conversation

bre1470
Copy link
Member

@bre1470 bre1470 commented Sep 3, 2024

No description provided.

@bre1470 bre1470 self-assigned this Sep 3, 2024
@bre1470 bre1470 force-pushed the feature/x-ray-connector branch from 30d9d9b to 0187c25 Compare September 3, 2024 17:16
@bre1470 bre1470 force-pushed the feature/x-ray-connector branch from 3287e3c to 5b01666 Compare September 5, 2024 11:21
@bre1470 bre1470 added the enhancement New feature or request label Sep 13, 2024
@bre1470 bre1470 marked this pull request as ready for review September 13, 2024 10:51
@bre1470 bre1470 requested a review from Eskils September 13, 2024 11:06
Copy link
Contributor

@Eskils Eskils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thorough job on this connector. 🙌 My feedback is just nitpick.

src/XRay/XRayConnector.ts Show resolved Hide resolved
src/XRay/XRayConnector.ts Show resolved Hide resolved
src/XRay/XRayOptions.ts Outdated Show resolved Hide resolved
test/unit-tests/XRay/Breakdown.test.ts Outdated Show resolved Hide resolved
@bre1470 bre1470 merged commit 0e378b9 into main Sep 17, 2024
5 checks passed
@bre1470 bre1470 deleted the feature/x-ray-connector branch September 17, 2024 07:37
@bre1470 bre1470 added this to the Next milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants