Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Morningstar Regulatory News Announcements connector #3

Merged
merged 15 commits into from
Jul 31, 2024
Merged

Implement Morningstar Regulatory News Announcements connector #3

merged 15 commits into from
Jul 31, 2024

Conversation

Eskils
Copy link
Contributor

@Eskils Eskils commented Jul 30, 2024 •
edited
Loading

This PR aims to implement a Dashboards data pool connector to Morningstar’s Regulatory News Announcements.

NOTE: This feature has yet to be tested on Morningstar’s API

Considerations

  • Test APIs: The code has not yet been tested on Morningstar’s Production APIs, only a mock API.
  • Hook up External deps: The demo does not work.
  • Demo: If the user pays for each query, it might be in Highsoft/the user’s interest to not have the demo query Morningstar. I assume there will be more demos connecting to Morningstar, so this consideration is likely something that has been discussed?

@Eskils Eskils requested a review from bre1470 July 30, 2024 09:11
@Eskils Eskils marked this pull request as ready for review July 30, 2024 09:11
bre1470
bre1470 requested changes Jul 30, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Some stuff needs to be addressed.

In addition:

  • merge main
  • run husky, so eslint validates code style
  • add trailing new line for demo files

src/RNANews/README.md Outdated Show resolved Hide resolved
src/RNANews/RNANewsConnector.ts Outdated Show resolved Hide resolved
src/RNANews/RNANewsJSON.ts Show resolved Hide resolved
src/Shared/MorningstarSearchParams.ts Outdated Show resolved Hide resolved
@Eskils
Copy link
Contributor Author

Eskils commented Jul 30, 2024

Changed some of the addressed issues, implementing json validation remains before re-review.

@Eskils Eskils requested a review from bre1470 July 31, 2024 07:09
bre1470
bre1470 approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@bre1470 bre1470 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@bre1470 bre1470 merged commit cadf54d into main Jul 31, 2024
1 check passed
@bre1470 bre1470 deleted the feature/implement-rna-news-connector branch July 31, 2024 09:44
@bre1470
Copy link
Member

bre1470 commented Jul 31, 2024

Awesome work. Now we just have to wait for the Dashboards fixes and can then do some demos.

@bre1470 bre1470 added this to the v0.1.0 milestone Jul 31, 2024
@bre1470 bre1470 added the enhancement New feature or request label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bre1470 bre1470 bre1470 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Eskils @bre1470