Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GoalAnalysisConnector. #31

Merged
merged 10 commits into from
Sep 30, 2024
Merged

Added GoalAnalysisConnector. #31

merged 10 commits into from
Sep 30, 2024

Conversation

bre1470
Copy link
Member

@bre1470 bre1470 commented Sep 12, 2024

  • Solve issue with authorization 102 (maybe wrong endpoint path?)

@bre1470 bre1470 added the enhancement New feature or request label Sep 12, 2024
@bre1470 bre1470 added this to the Next milestone Sep 12, 2024
@bre1470 bre1470 self-assigned this Sep 12, 2024
@bre1470 bre1470 removed this from the Next milestone Sep 12, 2024
@bre1470 bre1470 closed this Sep 18, 2024
@bre1470 bre1470 deleted the feature/goal-analysis-connector branch September 18, 2024 13:54
@bre1470 bre1470 reopened this Sep 23, 2024
@bre1470 bre1470 marked this pull request as ready for review September 23, 2024 13:16
@bre1470 bre1470 marked this pull request as draft September 23, 2024 13:16
@bre1470 bre1470 requested a review from Eskils September 23, 2024 13:17
@bre1470 bre1470 marked this pull request as ready for review September 25, 2024 09:39
Copy link
Contributor

@Eskils Eskils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. 🙌

I had a small nitpick on documentation.

src/GoalAnalysis/GoalAnalysisOptions.ts Show resolved Hide resolved
@bre1470 bre1470 merged commit f8962d7 into main Sep 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants