feature/demo-page #63
Conversation
bm64
requested review from
pawelfus,
DJTechnoo,
pawellysy and
kamil-musialowski
There was a problem hiding this comment.
Nice! A few things, see my comments inline.
In addition: Could you add fetching the env file just once, then store it in the localStorage? So we don't have to search for the env file when scanning through demos. I mean: whichever demo loads the env file first, store it in the localStorage. And each demo should first check localStorage for this JSON file. If exists, load it, create chart and hide the button and description about uploading the file.
Edit:
In addition, there's a few errors in console:
| <span>API</span> | ||
| </div> | ||
| </a> | ||
| <a href="https://shop.highcharts.com/" target="_blank" class="cart"> |
There was a problem hiding this comment.
Let's change URL to: https://shop.highcharts.com/contact/partner-data
| </div> | ||
| </div> | ||
| <iframe id="demoIframe" class="iframe" src="dashboards-rna-news/demo.html"></iframe> | ||
| </div> | ||
| </body> |
There was a problem hiding this comment.
Missing footer with copyright
| </div> | ||
| <h2>Demo Headline</h2> | ||
| <div class="sidebar-navigation"> | ||
| <h3>Demo category</h3> |
| </a> | ||
| </div> | ||
| </div> | ||
| <h2>Demo Headline</h2> |
There was a problem hiding this comment.
Rename: Morningstar Connectors Demos
|
|
||
| .sidebar button:hover, | ||
| .sidebar button.selected { | ||
| background: #F0F1FF; |
| border-bottom: 1px solid #E3E3E8; | ||
| } | ||
|
|
||
| .sidebar button { |
Implement designs for morningstar connector demos page.