fix/resources-release #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…servers and clearing intervals.
jszuminski
reviewed
Apr 11, 2024
jszuminski
reviewed
Apr 22, 2024
There was a problem hiding this comment.
I've noticed that when running npm run node-tests I get the following error:
[Fail] Node module from file: options_stringified.json, took: 133ms.
Mon Apr 22 2024 10:21:12 GMT+0200 [error] - Cannot create property 'chart' on string '{"title":{"text":"Stringified options"},"xAxis":{"categories":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"]},"series":[{"type":"column","data":[1,3,2,4]},{"type":"column","data":[5,3,4,2]}]}'
TypeError: Cannot create property 'chart' on string '{"title":{"text":"Stringified options"},"xAxis":{"categories":["Jan","Feb","Mar","Apr","May","Jun","Jul","Aug","Sep","Oct","Nov","Dec"]},"series":[{"type":"column","data":[1,3,2,4]},{"type":"column","data":[5,3,4,2]}]}'
at doExport (file:///Users/jakubszuminski/Documents/Coding/Highcharts/exporting/node-export-server/lib/chart.js:360:21)
at Object.startExport (file:///Users/jakubszuminski/Documents/Coding/Highcharts/exporting/node-export-server/lib/chart.js:108:11)
at file:///Users/jakubszuminski/Documents/Coding/Highcharts/exporting/node-export-server/tests/node/node_test_runner.js:95:18
at new Promise (<anonymous>)
at file:///Users/jakubszuminski/Documents/Coding/Highcharts/exporting/node-export-server/tests/node/node_test_runner.js:72:13
at Array.map (<anonymous>)
at file:///Users/jakubszuminski/Documents/Coding/Highcharts/exporting/node-export-server/tests/node/node_test_runner.js:70:10
but I've checked and it appears on master as well so this is not a part of this pull request.
|
@jszuminski Thanks for the reveiw and noticing the problem with the test. Will investigate it separately and fix it. |
|
FYI this PR appears to remove the |
|
@mikemeerschaert Thanks for noticing that! The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fixes and corrections to releasing pool and resources, closing servers and clearing intervals.