Make userOptions of the chart available within customCode context #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the chart options available again in the customCode context which is compatible to the previous, phantomjs/node export server. Fixes highcharts#548
jszuminski
reviewed
Aug 1, 2024
There was a problem hiding this comment.
Overall, looks good to me, thanks! @PaulDalek could you take a look?
jszuminski
requested changes
Aug 1, 2024
There was a problem hiding this comment.
@level420 could you please add this change under Fixes in the changelog for v4.1.0?
PaulDalek
approved these changes
Aug 1, 2024
|
@jszuminski @PaulDalek I think this PR is ready to be merged. |
jszuminski
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the chart options available again in the customCode context which is compatible to the previous, phantomjs/node export server. Fixes #548