-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed css escape chars #4104
base: main
Are you sure you want to change the base?
fixed css escape chars #4104
Conversation
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +68 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +56 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +67 B View Changes
|
@joshgoebel any input ? |
src/languages/css.js
Outdated
@@ -14,7 +14,7 @@ export default function(hljs) { | |||
const VENDOR_PREFIX = { begin: /-(webkit|moz|ms|o)-(?=[a-z])/ }; | |||
const AT_MODIFIERS = "and or not only"; | |||
const AT_PROPERTY_RE = /@-?\w[\w]*(-\w+)*/; // @-webkit-keyframes | |||
const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*'; | |||
const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*(\\\\:[a-zA-Z0-9_-]+)*'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is ::
escaping supported? Or escaping any other chars? Feels like this is just handling this one edge case vs the concept of escaping in general - are there other uses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ive managed to generalize to include other special chars in the new commit pls review
src/languages/css.js
Outdated
{ begin: '(?<!\\\\):(' + css.PSEUDO_CLASSES.join('|') + ')'}, | ||
{ begin: '(?<!\\\\):(:)?(' + css.PSEUDO_ELEMENTS.join('|') + ')'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These (look-behind) are problematic until we hit v12 - as this would be a breaking change to introduce to v11 since it would change which browsers v11 supports (Safari was very late to this party).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it in the new pr
test/markup/css/pseudo-selector.txt
Outdated
@@ -22,3 +22,47 @@ p::first-letter { | |||
font-weight: bold; | |||
color: brown; | |||
} | |||
.dark\:hover\:bg-sky-500:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two or three (tops) of these longer examples should be sufficient unless there is some big difference here I'm missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay ill reduce the newer tc
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +130 B View Changes
|
Build Size ReportChanges to minified artifacts in 3 files changedTotal change +113 B View Changes
|
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +112 B View Changes
|
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +75 B View Changes
|
@@ -13,8 +13,9 @@ export default function(hljs) { | |||
const modes = css.MODES(hljs); | |||
const VENDOR_PREFIX = { begin: /-(webkit|moz|ms|o)-(?=[a-z])/ }; | |||
const AT_MODIFIERS = "and or not only"; | |||
const AT_PROPERTY_RE = /@-?\w[\w]*(-\w+)*/; // @-webkit-keyframes | |||
const IDENT_RE = '[a-zA-Z-][a-zA-Z0-9_-]*'; | |||
const AT_PROPERTY_RE = /@-?\b\w[\w-]*\b/; // @-webkit-keyframes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the changes here trying to do?
Resolves #3965
(fixed the branch issue)
before
after
Checklist
CHANGES.md