-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New credentials #2
Conversation
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
@tonisives what do you think in case of private key credentials, we actually ask for private key and private key id? HMKitCredentials credentials = new HMKitPrivateKeyCredentials(
"client_id",
"private_key_id",
"private_key_pem"
); |
It might be easier for users to copy/paste the json file contents. But negative is that if we change the json file keys/content then the parsing in hmkit-fleet fails Either option is fine with me |
I understand your concern. However I'd say people make mistake and then learn(or read the doc) and use it properly :D Let's go for explicit configuration and only pass what is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
HMKit can be intialized with either
HMKitOAuthCredentials
orHMKitPrivateKeyCredentials
.HMKitOAuthCredentials
:HMKitPrivateKeyCredentials