Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example added for searching using higlass-python #139

Conversation

smitkadvani
Copy link
Contributor

@smitkadvani smitkadvani commented Oct 17, 2023

Description

What was changed in this pull request?
This pull request adds an example to get search option on genome wide assembly. Example utilizes dataset of higlass.io

Why is it necessary?
It is necessary because hg.Viewconf function and view.viewconf().json() have different use cases but have similar alias.

Along with that, it's very unintuitive to identify usages of view.viewconf() to change viewconfig where we can add/update default arguments for root of viewconfig.

Fixes #___

Checklist

  • Unit tests added or updated
  • Update examples.ipynb notebook
  • Documentation added or updated
  • Updated CHANGELOG.md
  • Ran black on the root directory

Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Think there was a typo in the code example. Let me know what you think.

docs/getting_started.rst Outdated Show resolved Hide resolved
@smitkadvani smitkadvani reopened this Oct 18, 2023
Copy link
Member

@manzt manzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@manzt manzt merged commit 80034e2 into higlass:main Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants