-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Email Auth(#27) #147
Conversation
Hello there!👋 Welcome to the project!💖 |
@puru-ganda Update the PR as per the PR template and do attach a video of the auth too. |
@himanshusharma89 should i also need to implement sign up functionality?? |
@himanshusharma89 can you please add a USER to the firebase console and provide its EMAIL and PASSWORD details to me so that I can use that for verification in demo video |
@puru-ganda Email auth is enabled now. |
@himanshusharma89 okay, but I need a added USER email and password so that I can verify the email auth functionality |
Yeah, I almost forgot it. I'll create an issue for that and then you can start implementing it on that screen |
okay |
@puru-ganda Pull the latest code, the screen is added. You can start working on it |
sure |
@himanshusharma89 we can link this to an issue for it to get tracked |
Related Issue
Proposed Changes
Checklist
Demoemail_auth.mp4 |
We need a few changes here:
|
@puru-ganda Pull the latest code before working on it. |
okay |
@puru-ganda 30 files got changed for this PR, I think you didn't rebase your code perfectly, try it again. And also implement the email auth inside the AuthService class. |
Yes I was facing some issues with merge, I will implement email auth soon. |
@himanshusharma89 Can I create a new PR and close this one as I am facing issues with the current local branch EmailAuth. |
I don't encourage it, but go ahead, if you are not able to perform the task. |
okay |
No description provided.