Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Email Auth(#27) #147

Closed
wants to merge 11 commits into from
Closed

Conversation

puruganda
Copy link
Contributor

No description provided.

@welcome
Copy link

welcome bot commented Mar 20, 2021

Hello there!👋 Welcome to the project!💖
Thank you and congrats🎉 for opening your first pull request. Please make sure you have gone through our Code of Conduct and contributing files before making this pr. 🙌🙌 We will get back to you as soon as we can 😄.

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Mar 20, 2021
@himanshusharma89
Copy link
Owner

@puru-ganda Update the PR as per the PR template and do attach a video of the auth too.

@puruganda
Copy link
Contributor Author

@puru-ganda Update the PR as per the PR template and do attach a video of the auth too.

@himanshusharma89 should i also need to implement sign up functionality??

@puruganda
Copy link
Contributor Author

puruganda commented Mar 21, 2021

@himanshusharma89 can you please add a USER to the firebase console and provide its EMAIL and PASSWORD details to me so that I can use that for verification in demo video

@himanshusharma89
Copy link
Owner

@puru-ganda Email auth is enabled now.

@puruganda
Copy link
Contributor Author

@puru-ganda Email auth is enabled now.

@himanshusharma89 okay, but I need a added USER email and password so that I can verify the email auth functionality

@himanshusharma89
Copy link
Owner

@himanshusharma89 okay, but I need a added USER email and password so that I can verify the email auth functionality

Yeah, I almost forgot it. I'll create an issue for that and then you can start implementing it on that screen

@puruganda
Copy link
Contributor Author

@himanshusharma89 okay, but I need a added USER email and password so that I can verify the email auth functionality

Yeah, I almost forgot it. I'll create an issue for that and then you can start implementing it on that screen

okay

@himanshusharma89
Copy link
Owner

@puru-ganda Pull the latest code, the screen is added. You can start working on it

@puruganda
Copy link
Contributor Author

@puru-ganda Pull the latest code, the screen is added. You can start working on it

sure

@Rishabh510
Copy link
Collaborator

@himanshusharma89 we can link this to an issue for it to get tracked

@himanshusharma89 himanshusharma89 linked an issue Mar 22, 2021 that may be closed by this pull request
3 tasks
@himanshusharma89 himanshusharma89 added the Level3 hard gssoc issue label Mar 22, 2021
@puruganda
Copy link
Contributor Author

Related Issue

Proposed Changes

  • Added User Email Auth in login screen
  • Added User Registration using email and password in sign up screen
  • Added logout functionality
  • Added cutom_dialogalert widget for Auth functionality

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Change In Documentation

Demo

email_auth.mp4

@himanshusharma89
Copy link
Owner

We need a few changes here:

@himanshusharma89
Copy link
Owner

@puru-ganda Pull the latest code before working on it.

@puruganda
Copy link
Contributor Author

@puru-ganda Pull the latest code before working on it.

okay

@himanshusharma89
Copy link
Owner

@puru-ganda 30 files got changed for this PR, I think you didn't rebase your code perfectly, try it again. And also implement the email auth inside the AuthService class.

@puruganda
Copy link
Contributor Author

@puru-ganda 30 files got changed for this PR, I think you didn't rebase your code perfectly, try it again. And also implement the email auth inside the AuthService class.

Yes I was facing some issues with merge, I will implement email auth soon.

@puruganda
Copy link
Contributor Author

puruganda commented Mar 24, 2021

@himanshusharma89 Can I create a new PR and close this one as I am facing issues with the current local branch EmailAuth.
because I need to create a new branch and implement email auth on that.

@himanshusharma89
Copy link
Owner

@himanshusharma89 Can I create a new PR and close this one as I am facing issues with the current local branch EmailAuth.
because I need to create a new branch and implement email auth on that.

I don't encourage it, but go ahead, if you are not able to perform the task.

@puruganda
Copy link
Contributor Author

@himanshusharma89 Can I create a new PR and close this one as I am facing issues with the current local branch EmailAuth.
because I need to create a new branch and implement email auth on that.

I don't encourage it, but go ahead, if you are not able to perform the task.

okay

@puruganda puruganda closed this Mar 25, 2021
@puruganda puruganda deleted the EmailAuth branch March 25, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 Issues created for GSSOC'21 Level3 hard gssoc issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Authentication
3 participants