Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Auth added (Firebase Authentication) #196

Closed
wants to merge 4 commits into from
Closed

Apple Auth added (Firebase Authentication) #196

wants to merge 4 commits into from

Conversation

Mohitmadhav
Copy link
Contributor

Related Issue

Proposed Changes

  • Displays error for Android users that they are not an ios user
  • Added Apple Authentication code

Additional Information

  • Needs to be tested on an ios device since I didn't have ios, I couldn't do that.

Checklist

  • Tested
  • No Conflicts
  • Change In Code
  • Follows linting rules

Screenshots

Before this PR After this PR
Screenshot_20210417-143954 Screenshot_20210418-165208

@welcome
Copy link

welcome bot commented Apr 19, 2021

Hello there!👋 Welcome to the project!💖
Thank you and congrats🎉 for opening your first pull request. Please make sure you have gone through our Code of Conduct and contributing files before making this pr. 🙌🙌 We will get back to you as soon as we can 😄.

@github-actions github-actions bot added the GSSOC21 Issues created for GSSOC'21 label Apr 19, 2021
@SapinderSingh
Copy link
Contributor

@Mohitmadhav Please pull the latest code, and resolve the merge conflicts.

@Mohitmadhav
Copy link
Contributor Author

@Mohitmadhav Please pull the latest code, and resolve the merge conflicts.

@SapinderSingh @himanshusharma89 all the conflicts are resolved
Now can you check the auth?? If it works then there'll be no need for Codemagic (It's a bit lengthy 😅)

@himanshusharma89
Copy link
Owner

@Mohitmadhav I don't own a XCode, so do it with CodeMagic or I'll do it later

@himanshusharma89
Copy link
Owner

himanshusharma89 commented Apr 24, 2021

@Mohitmadhav Don't push in the same PR, create new brach for every new task. And do git pull before pushing

@Rishabh510
Copy link
Collaborator

@Mohitmadhav Don't push in the same PR, create new brach for every new task. And do git pull before pushing

Are we doing the iOS part along with the Android part or we'll do that after the prototype for Android is complete?
I suggest we create a separate branch for iOS part temporarily so that any iOS related changes can be fetched from there itself. Whats your opinion @himanshusharma89

@himanshusharma89
Copy link
Owner

@Rishabh510 There is no need to create a separate branch for iOS, all the changes need to be done in the ios folder. The concepts logic will stay in lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSOC21 Issues created for GSSOC'21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Authentication
4 participants