When invited to a room the bot should not join if the room is public #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rberrelleza
reviewed
Feb 12, 2018
| if rooms | ||
| for room in rooms | ||
| if [email protected]_join_public && room.guest_url != '' && room.jid == jid | ||
| @logger.info "Not joining #{room.jid} because it is a public room" |
There was a problem hiding this comment.
If you don't join the room, you won't be able to receive messages from that room. Is that the objective?
There was a problem hiding this comment.
Yeh, if you tell hubot not to join public rooms it only applies at boot. Thought if invited whilst it is running it will then join a public room
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you tell hubot not to join public rooms it only applies at start up not when the bot is running, this way the bot will only join a room whilst it is running if the room is not public.