Support for basic Rectangle operations. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de-emacs into feature_rectangles_wip
Fix for issue hiro-sun#27. The following operations are supported: 1. C-x r r Copy rectangle to register 2. C-x r i Insert rectangle from register 3. C-x r d Delete rectangle 4. C-x r k Kill rectangle 5. C-x r y Yank rectangle 6. C-x r o Open rectangle, shifting text right 7. C-x r c Blank out rectangle 8. C-x r t Replace rectangle contents with string on each line Known issues: Cursor movement(s). Above mentioned rectangle operations do differ from Emacs as follows: 1. Cursor placement at the end of operation is different than Emacs' The reason for that is setSelection's behavior inside the transaction seems to be somewhat erratic, and using is somewhat complicated (and not done at all for the moment). TODO: This problem might be solvable on vscode-emacs side. INVESTIGATE! 2. Unlike Emacs, VSCode does not seem to treat cursor movement as a part of transaction. Therefore, undo does not result in the same cursor movement as with Emacs.
…de-emacs into feature_rectangles_wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #27.
The following operations are supported:
Known issues:
Cursor movement(s). Above mentioned rectangle operations do differ
from Emacs as follows:
The reason for that is setSelection's behavior inside the transaction
seems to be somewhat erratic, and using is somewhat complicated (and
not done at all for the moment).
TODO: This problem might be solvable on vscode-emacs side. INVESTIGATE!
a part of transaction. Therefore, undo does not result in the same
cursor movement as with Emacs.