Skip to content

Commit

Permalink
[GridNG] Updating grid-baseline-align-cycles-001.html
Browse files Browse the repository at this point in the history
This CL updates this test to match expectations where baseline
alignment should not apply. The CSS Grid spec indicates that baseline
alignment should not apply in cases where there's a cyclic dependency
on sizing in the dimension where baseline alignment applies. However,
it also states that certain conditions will force another sizing pass,
and under such conditions baseline alignment may be possible, and under
these circumstances, baseline alignment should apply. If we were to
change behavior to match this test case, numerous other second pass
baseline tests would break. In fact, this test was actually matching
the old expected results before we added logic to support second
passes on baseline alignment - see
https://chromium-review.googlesource.com/c/chromium/src/+/2873217.

Instead, this change updates the test expectations so that they are
all situations where baseline alignment should never apply.

Bug: 941987
Change-Id: Icec9ec1a2708f488dd2dd0d6c472859b36fb2460
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911306
Commit-Queue: Kurt Catti-Schmidt <[email protected]>
Commit-Queue: Ian Kilpatrick <[email protected]>
Reviewed-by: Ian Kilpatrick <[email protected]>
Cr-Commit-Position: refs/heads/master@{#886493}
  • Loading branch information
KurtCattiSchmidt authored and chromium-wpt-export-bot committed May 25, 2021
1 parent c142d0e commit 0895a4d
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions css/css-grid/alignment/grid-baseline-align-cycles-001.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@
A grid item whose size is input
to the size of the track
on which its size depends
cannot participate in baseline alignment.
cannot participate in baseline alignment, unless
the grid algorithm requires
another pass, where the track
sizing can be resovled.
">
<link rel="help" href="https://www.w3.org/TR/css-grid-1/#row-align">
<link rel="match" href="references/grid-baseline-align-cycles-001-ref.html">
Expand Down Expand Up @@ -55,7 +58,7 @@
<div class="index">
X
</div>
<div class="percent">
<div class="percent orthogonal">
X
</div>
</div>
Expand Down

0 comments on commit 0895a4d

Please sign in to comment.