Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GridNG] Updating grid-baseline-align-cycles-001.html
This CL updates this test to match expectations where baseline alignment should not apply. The CSS Grid spec indicates that baseline alignment should not apply in cases where there's a cyclic dependency on sizing in the dimension where baseline alignment applies. However, it also states that certain conditions will force another sizing pass, and under such conditions baseline alignment may be possible, and under these circumstances, baseline alignment should apply. If we were to change behavior to match this test case, numerous other second pass baseline tests would break. In fact, this test was actually matching the old expected results before we added logic to support second passes on baseline alignment - see https://chromium-review.googlesource.com/c/chromium/src/+/2873217. Instead, this change updates the test expectations so that they are all situations where baseline alignment should never apply. Bug: 941987 Change-Id: Icec9ec1a2708f488dd2dd0d6c472859b36fb2460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2911306 Commit-Queue: Kurt Catti-Schmidt <[email protected]> Commit-Queue: Ian Kilpatrick <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/master@{#886493}
- Loading branch information