Skip to content

Commit

Permalink
Fix WPT for cross-partition blob URL navigation
Browse files Browse the repository at this point in the history
When `window.open` is performed with 'noopener' a null handle is returned regardless of whether the navigation succeeded.

Bug: 359245744
Change-Id: I027e218b42936bdad5c0f4272f6a613978dc79de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5871987
Reviewed-by: Andrew Williams <[email protected]>
Commit-Queue: Kyra Seevers <[email protected]>
Reviewed-by: Kyra Seevers <[email protected]>
Auto-Submit: Janice Liu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1357219}
  • Loading branch information
Jenny-233 authored and chromium-wpt-export-bot committed Sep 18, 2024
1 parent 4d67f35 commit f389d33
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@
// Attempt to open blob URL in cross partition iframe.
await send(cross_site_iframe_uuid, does_blob_url_open_return_handle(blob_url, response_queue_uuid));
const response_1 = await receive(response_queue_uuid);
if (response_1 !== navigation_handle_not_null) {
reject(`Blob URL wasn't opened in not-same-top-level-site iframe: ${response_1}`);
if (response_1 !== navigation_handle_null) {
reject(`Blob URL handle wasn't null in not-same-top-level-site iframe: ${response_1}`);
}
const noopener_response_1 = await receive(noopener_response_queue);
if (noopener_response_1 !== opener_null_response) {
Expand Down

0 comments on commit f389d33

Please sign in to comment.