Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): recent link testnet #1596

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

guspan-tanadi
Copy link

Description

Navigate a link to testnet page.

Breaking change?

Example


Checklist

  • Tests added in this PR (if applicable)

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2024

CLA assistant check
All committers have signed the CLA.

@hugocaillard
Copy link
Collaborator

hugocaillard commented Oct 28, 2024

The link below is outdated as well, maybe this all section should just link to https://docs.hiro.so/stacks/clarinet/concepts/network-types

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link below is outdated as well, maybe this all section should just link to https://docs.hiro.so/stacks/clarinet/concepts/network-types

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think thie bullet points should be removed, and instead have something like

[...] allowing you to deploy the contract to the [devnet, testnet, or mainnet](link/to/doc)

Since the docs now explain the diff between the network, there's no need to explain it here

Copy link
Collaborator

@hugocaillard hugocaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @guspan-tanadi

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@hugocaillard hugocaillard enabled auto-merge (squash) December 17, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In Progress
Development

Successfully merging this pull request may close these issues.

3 participants