Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - Clarinet format #1609

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

WIP - Clarinet format #1609

wants to merge 33 commits into from
+1,503 −3

Conversation

tippenein
Copy link
Collaborator

@tippenein tippenein commented Nov 12, 2024 •
edited
Loading

remaining work

  • fix pre- and post-comments
  • top level max-line breaking
  • @format-ignore comments (possibly pushed off until post-mvp)
  • LSP/VSCode integration (draft: lsp format #1632)
  • passing golden test suite

@tippenein tippenein marked this pull request as draft November 12, 2024 19:19
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.86337% with 137 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
components/clarinet-format/src/formatter/mod.rs 89.44% 84 Missing ⚠️
components/clarinet-cli/src/frontend/cli.rs 0.00% 53 Missing ⚠️

📢 Thoughts on this report? Let us know!

@tippenein tippenein force-pushed the clarinet-format branch 2 times, most recently from 5057d1b to cefc2bf Compare December 3, 2024 00:38
@diwakergupta diwakergupta mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugocaillard hugocaillard hugocaillard left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tippenein @hugocaillard