Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with @stacks.js/* and various minor improvements #57

Merged
merged 8 commits into from
Dec 4, 2020

Conversation

markmhendrickson
Copy link
Contributor

@markmhendrickson markmhendrickson commented Nov 30, 2020

  • Integrate @stacks/auth instead of @blockstack/connect
  • Reduce Stacks-related code duplication with new stacks module
  • Improve README with new screenshot
  • Normalize naming around "Todos" instead of "To-do list" etc.
  • Broaden scope of homepage tagline
  • Simplify package name and add author
  • Fix minor React-related console warnings

This PR resolves / supplants #53 and is needed mainly to update content found at https://docs.blockstack.org/authentication/building-todo-app to see how Stacks.js is used to integrate authentication.

@markmhendrickson markmhendrickson requested review from hstove and yknl and removed request for hstove November 30, 2020 19:14
@markmhendrickson markmhendrickson changed the title Update with @stacks.js/auth and various minor improvements Update with @stacks.js/* and various minor improvements Nov 30, 2020
Copy link
Contributor

@yknl yknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmhendrickson
Copy link
Contributor Author

@kyranjamie Mind reviewing again with particular focus on the stacks.js module? I've refactored more of the @stacks/* imports into it so that we can reference them all in one place from the docs and keep things simpler for readers.

@kyranjamie
Copy link
Contributor

I can, though following discussion here, maybe we want to wait before merging this if we're going to change the packaging structures so that connect exports auth, rather than this way around.

@markmhendrickson
Copy link
Contributor Author

I'd prefer not to make that packages discussion blocking here since the related documentation is currently broken and need these changes urgently to fix them.

Copy link
Contributor

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @markmhx

I'd be inclined to rename src/stacks.js to stacks-auth or something to be a bit more descriptive what it contains, otherwise looks clean.

@markmhendrickson
Copy link
Contributor Author

@kyranjamie I've improved the relevant src libraries into auth.js and storage.js. Mind taking another look?

@kyranjamie
Copy link
Contributor

All good

@markmhendrickson markmhendrickson merged commit fd5d23e into master Dec 4, 2020
@markmhendrickson markmhendrickson deleted the feat/stacks-auth branch December 4, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants