feat: use bns-2 branch of connect #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmhendrickson
suggested changes
Apr 9, 2021
| }, | ||
| redirectTo: '/', | ||
| authOrigin: 'https://pr-1103.app.stacks.engineering/', |
There was a problem hiding this comment.
Do we want to hardcode this URL? Presumably that will mess things up upon deploy to todos.blockstack.org
There was a problem hiding this comment.
Awaiting registrar on mainnet
|
Some insights on the use cases will be helpful for testing purposes |
|
It appears this PR should go back into development to update the As importantly, the version of connect installed as a dependency should be whatever is in production now and not |
|
@fbwoolf to review and close if irrelevant now |
|
I believe this is outdated so I'm going to close. I don't see an existing branch in connect related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses version of
@stacks/connectfrom leather-io/extension#1103