refactor: #13 keeping codes clean.

hiroxpepe · Mar 17, 2022 · 1d3462c · 1d3462c
1 parent 6a62f70
commit 1d3462c
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 14 deletions.
diff --git a/MidiPlayer.FluidSynth/Synth.cs b/MidiPlayer.FluidSynth/Synth.cs
@@ -353,13 +353,13 @@ static Multi() {
             }
 
             ///////////////////////////////////////////////////////////////////////////////////////////
-            // static Properties [noun, noun phrase, adjective]
+            // internal static Properties [noun, noun phrase, adjective]
 
-            public static List<Track> List {
+            internal static List<Track> List {
                 get => _trackMap.Select(x => x.Value).ToList();
             }
 
-            public static StandardMidiFile StandardMidiFile {
+            internal static StandardMidiFile StandardMidiFile {
                 get => _standardMidiFile;
                 set {
                     _standardMidiFile = value;
@@ -368,33 +368,33 @@ public static StandardMidiFile StandardMidiFile {
             }
 
             ///////////////////////////////////////////////////////////////////////////////////////////
-            // public static Methods [verb, verb phrases]
+            // internal static Methods [verb, verb phrases]
 
             /// <summary>
             /// NOTE_ON = 144
             /// </summary>
-            public static void ApplyNoteOn(int channel) {
+            internal static void ApplyNoteOn(int channel) {
                 _trackMap.Where(x => x.Value.Channel == channel).ToList().ForEach(x => x.Value.Sounds = true);
             }
 
             /// <summary>
             /// NOTE_OFF = 128
             /// </summary>
-            public static void ApplyNoteOff(int channel) {
+            internal static void ApplyNoteOff(int channel) {
                 _trackMap.Where(x => x.Value.Channel == channel).ToList().ForEach(x => x.Value.Sounds = false);
             }
 
             /// <summary>
             /// PROGRAM_CHANGE = 192
             /// </summary>
-            public static void ApplyProgramChange(int channel, int program) {
+            internal static void ApplyProgramChange(int channel, int program) {
                 _trackMap.Where(x => x.Value.Channel == channel).ToList().ForEach(x => x.Value.Program = program);
             }
 
             /// <summary>
             /// CONTROL_CHANGE = 176
             /// </summary>
-            public static void ApplyControlChange(int channel, int control, int value) {
+            internal static void ApplyControlChange(int channel, int control, int value) {
                 // BANK_SELECT_MSB =  0 [-- drums: 127 --]
                 //     _type: 176, _control:  0, _value: 127
                 // BANK_SELECT_LSB = 32
@@ -428,7 +428,7 @@ public static void ApplyControlChange(int channel, int control, int value) {
             /// <summary>
             /// get a trak by index.
             /// </summary>
-            public static Track GetBy(int index) {
+            internal static Track GetBy(int index) {
                 var track = _trackMap[index];
                 return track;
             }

diff --git a/MidiPlayer.SoundFont/SoundFont .cs b/MidiPlayer.SoundFont/SoundFont .cs
@@ -61,13 +61,13 @@ public string GetVoice(int bank, int prog) {
         class Voice {
 
             ///////////////////////////////////////////////////////////////////////////////////////////
-            // Properties [noun, noun phrase, adjective] 
+            // internal Properties [noun, noun phrase, adjective] 
 
-            public int Prog {
+            internal int Prog {
                 get; set;
             }
 
-            public string Name {
+            internal string Name {
                 get; set;
             }
         }

diff --git a/MidiPlayer/Conf.cs b/MidiPlayer/Conf.cs
@@ -18,12 +18,15 @@ public class Conf {
         static Json _json = null;
 
         ///////////////////////////////////////////////////////////////////////////////////////////////
-        // static Properties [noun, noun phrase, adjective] 
+        // internal static Properties [noun, noun phrase, adjective] 
 
-        public static bool Ready {
+        internal static bool Ready {
             get => !(_json is null);
         }
 
+        ///////////////////////////////////////////////////////////////////////////////////////////////
+        // public static Properties [noun, noun phrase, adjective] 
+
         public static App Value {
             get {
                 if (_json is null) {