Merge pull request #65 from hiroxpepe/develop

refactor: #13 keeping codes clean.
hiroxpepe · Mar 3, 2022 · e5b5920 · e5b5920
2 parents fbb995c + e32e170
commit e5b5920
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/MidiPlayer.Droid/MainActivity.cs b/MidiPlayer.Droid/MainActivity.cs
@@ -45,7 +45,7 @@ public override void OnRequestPermissionsResult(int requestCode, string[] permis
             base.OnRequestPermissionsResult(requestCode, permissions, grantResults);
         }
 
-        protected override void OnCreate(Bundle savedInstanceState) {
+        protected override void OnCreate(Bundle? savedInstanceState) {
             base.OnCreate(savedInstanceState);
             requestPermissions();
             Platform.Init(this, savedInstanceState);
@@ -107,7 +107,7 @@ protected override void OnDestroy() {
             }
         }
 
-        protected override void OnActivityResult(int requestCode, [GeneratedEnum] Result resultCode, Intent data) {
+        protected override void OnActivityResult(int requestCode, [GeneratedEnum] Result resultCode, Intent? data) {
             switch (requestCode) {
                 case (int) Request.SoundFont:
                     _soundFontPath = getActualPathBy(data);

diff --git a/MidiPlayer.FluidSynth/Synth.cs b/MidiPlayer.FluidSynth/Synth.cs
@@ -41,9 +41,9 @@ public class Synth {
 
         static Action<object, PropertyChangedEventArgs> _onUpdated;
 
-        static string _soundFontPath;
+        static string _soundFontPath = string.Empty;
 
-        static string _midiFilePath;
+        static string _midiFilePath = string.Empty;
 
         static SoundFontInfo _soundFontInfo;
 
@@ -439,7 +439,7 @@ public Track(int index) {
             /// <summary>
             /// implementation for INotifyPropertyChanged
             /// </summary>
-            public event PropertyChangedEventHandler PropertyChanged;
+            public event PropertyChangedEventHandler? PropertyChanged;
 
             ///////////////////////////////////////////////////////////////////////////////////////////
             // Properties [noun, noun phrase, adjective]