Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using font #29

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix using font #29

merged 1 commit into from
Sep 29, 2023

Conversation

Ptosiek
Copy link
Contributor

@Ptosiek Ptosiek commented Sep 28, 2023

Hi!
Not sure if the feature is used?

  1. The font "Yantramanav-Black.ttf" is not source so I remove the code handling it.
  2. Using self.app.setFont(font), instead of setting it manually to some components
  3. Can't test on MacOS, so the full_path of the font is given to QtGui.QFontDatabase.addApplicationFont
    via os.path.join(os.getcwd(), "fonts", self.config.G_FONT_FILE). But don't know if it's necessary

@hishizuka
Copy link
Owner

Hi @Ptosiek ,
Thank you for your PR.

1 I used to specify a default font. Now you can specify it in setting.conf, so remove it.
2. OK, thanks.
3. MacOS font specification was difficult and its test code was left behind. Let's delete it.

@hishizuka hishizuka merged commit b1dd32f into hishizuka:master Sep 29, 2023
@Ptosiek Ptosiek deleted the fix-font-handling branch October 4, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants