improve bluetooth/wifi on/off settings #37
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Work in progress]
1.I'd rather not used rfkill for wifi too (I end up having to reboot the system anyway to get it back, one way could be to do "ip link set xxx down/up", I think in both case, rfkill or this, the wifi module is powered anyway) ?
2.I realize now the IS_RASPI in some places is because you are running the code on MacOS and can't can't run linux command. So this def won't work for you.
But then, maybe we should introduce a IS_RASPI and IS_LINUX (or IS_VALID_PLATFORM) so these code paths can be tested on a computer too ?