Allow fetching past members in the API #1378
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 23, 2021
carlobeltrame
force-pushed
the
allow-fetching-past-members
branch
from
ac4a03a
to
b9faa03
Compare
carlobeltrame
force-pushed
the
allow-fetching-past-members
branch
from
b9faa03
to
a85b04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an WIP effort to deprecate the group_health endpoints in the PBS wagon in favor of an alternative architecture based on OAuth API access.
Wagons can add an ability that grants the permission
:show_past_memberson a group in order to allow fetching people with deleted roles through the API and web application.This PR also adds a convenience filter
with_deletedin addition to the existingdeletedrole filter, for easier use of the API by third-party applications that need to read the deleted people.Also exposes the group type and role type of all roles in the OAuth profile endpoint, since the PBS healthcheck application needs access to those as well. In fact, any application that includes some permission logic based on the hitobito roles exposed in OAuth can benefit from this addition.
See digio-ch/pbs-healthcheck-core#22 for more context. Prerequisite for digio-ch/pbs-healthcheck-core#28