Validate course number #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simfeld
commented
Mar 9, 2024
| @@ -13,6 +13,8 @@ module Pbs::Event::Course | |||
| APPROVALS = %w(requires_approval_abteilung requires_approval_region | |||
| requires_approval_kantonalverband requires_approval_bund).freeze | |||
|
|
|||
| COURSE_NUMBER_REGEX = /\APBS CH(?: [A-Z]{2})? [0-9]{3}-[0-9]{2}\z/.freeze | |||
There was a problem hiding this comment.
Following what's specified in https://pilot.scouts.ch (page 12 in the current version)
| if: :validate_number? } | ||
|
|
||
| def validate_number? | ||
| (new_record? || number_changed? || kind_id_changed?) && kind.validate_course_number |
There was a problem hiding this comment.
It should be possible to update existing records as long as course number and event kind are left untouched
simfeld
force-pushed
the
feature/validate-course-number
branch
from
578d877
to
7201c7c
Compare
TheWalkingLeek
requested changes
Mar 26, 2024
| if: :validate_number? } | ||
|
|
||
| def validate_number? | ||
| (new_record? || number_changed? || kind_id_changed?) && kind.validate_course_number |
There was a problem hiding this comment.
Suggested change
| (new_record? || number_changed? || kind_id_changed?) && kind.validate_course_number | |
| return false unless kind.validate_course_number? | |
| new_record? || | |
| number_changed? || | |
| kind_id_changed? |
Find ich persönlich leserlicher
…kinds.rb Co-authored-by: Nils Rauch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.