Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(28713): change generated name for array items #708

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vanch3d
Copy link
Contributor

@vanch3d vanch3d commented Dec 16, 2024

See https://hivemq.kanbanize.com/ctrl_board/57/cards/28713/details/

The PR change the pattern of the default name for items in a RJSF form.

  • the pattern in used is more readable: name #1 - content
  • the default name is item
  • if a ui:title is given, then it replaces the name

Note that the fix involves overriding a name that is hardcoded by the RJSF library. It might not be resilient to code updates.

Before

screenshot-localhost_3000-2024_12_16-09_13_30

After

screenshot-localhost_3000-2024_12_16-09_12_58

@vanch3d vanch3d self-assigned this Dec 16, 2024
@cla-bot cla-bot bot added the cla-signed label Dec 16, 2024
@vanch3d vanch3d marked this pull request as ready for review December 16, 2024 09:15
@sfrehse
Copy link
Contributor

sfrehse commented Dec 16, 2024

@vanch3d is the ui:title provided by all protocol adapters?

@vanch3d vanch3d force-pushed the fix/28713/array-item-index branch from b4ef66d to 8716bf0 Compare December 16, 2024 14:26
@vanch3d
Copy link
Contributor Author

vanch3d commented Dec 16, 2024

@vanch3d is the ui:title provided by all protocol adapters?

It's defined for mappings; any other array in forms will be item

@vanch3d vanch3d force-pushed the fix/28713/array-item-index branch from 8716bf0 to 487cbeb Compare December 16, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants