Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MistralV2 Format #5118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support MistralV2 Format #5118

wants to merge 2 commits into from

Conversation

noiji
Copy link

@noiji noiji commented Aug 8, 2024 •
edited
Loading

What does this PR do?

Supports MistralV2 format, which adds the system prompt prior to the last user message.

https://github.com/mistralai/mistral-common/blob/main/src/mistral_common/tokens/tokenizers/sentencepiece.py#L282

Before submitting

Works to be done

  • move system prompt within [INST] [\INST]

@hiyouga hiyouga added the pending This problem is yet to be addressed label Aug 9, 2024
@noiji noiji changed the title (WIP) Support MistralV2 Format Support MistralV2 Format Aug 11, 2024
@noiji noiji marked this pull request as ready for review August 11, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending This problem is yet to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noiji @hiyouga