Review of advanced forms chapter #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddonym
commented
Dec 20, 2024
| @@ -385,6 +400,8 @@ We can do this because the database on our laptop is only used for dev, so the d | |||
| In <<chapter_18_second_deploy>>, we'll deploy our new code to production, | |||
| and discuss what to do if we run into migrations and data integrity issues at that point. | |||
|
|
|||
| // DAVID: Shall we get them to run migrations again, since they deleted the database? | |||
There was a problem hiding this comment.
Update - we definitely should do this because otherwise when they try to start up the application in a subsequent chapter, it won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking good. A few small issues that I noticed though.
A general point: I feel like just because we're doing TDD doesn't mean we can't occasionally start up the application and use it to figure out what's happening. It feels like a long time since we've done that!