Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 19 #338

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chapter 19 #338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion chapter_19_spiking_custom_auth.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ We've got enough things we need to learn as it is!


Let's switch on our new accounts app in _settings.py_:
// JAN: I have "lists.apps.ListsConfig" inside INSTALLED_APPS "lists"

[role="sourcecode"]
.src/superlists/settings.py (ch18l008-1)
Expand Down Expand Up @@ -495,6 +496,8 @@ class ListUser(AbstractBaseUser):
----
====

// JAN: Do we really need is_staff here?

That's what I call a minimal user model!
One field, none of this firstname/lastname/username nonsense,
and, pointedly, no password!
Expand Down Expand Up @@ -883,6 +886,7 @@ selenium.common.exceptions.NoSuchElementException: Message: Unable to locate
element: input[name=email]; [...]
[...]
----
// JAN: I see the following exception: ModuleNotFoundError: No module named 'accounts', not the selenium one. We should remove all changes from settings.py/urls.py as well

The first thing it wants us to do is add an email input element. Bootstrap has
some built-in classes for navigation bars, so we'll use them, and include a
Expand Down Expand Up @@ -1376,7 +1380,7 @@ class Token(models.Model):
uid = models.CharField(default=uuid.uuid4, max_length=40)
----
====

// JAN: I think it would be worth mentioning why uuid.uuid4 isn't called. Can be confusing for people when first seeing this

And, perhaps with a bit more wrangling of migrations,
that should get us to passing tests:
Expand Down
Loading