Review of mocking 1 #345
Open
Review of mocking 1 #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seddonym
commented
Dec 20, 2024
| @@ -1429,5 +1465,5 @@ Mocks can leave you tightly coupled to the implementation:: | |||
| As we saw in <<mocks-tightly-coupled-sidebar>>, | |||
| mocks can leave you tightly coupled to your implementation. | |||
| For that reason, you shouldn't use them unless you have a good reason. | |||
|
|
|||
| // DAVID: When rendered, this last point says the same phrase three times in a row. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like the pragmatic approach you take to mocking here (especially consider we both know they are BAD!) In particular I think the messages framework is a great way of making the point.
I think a bit more explanation for the Django bits wouldn't go amiss - and as I say in the comment, perhaps even ditch the whole authentication backend for a lower-level approach that uses the session framework directly.
It might also be worth drawing the distinction between mocking and monkeypatching, and the trade offs involved with each. Maybe also some more strongly worded advice against directly monkeypatching attributes in tests without tidying up afterwards.