Review of chapter 21 #346
Open
Review of chapter 21 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a pretty long chapter, full of valuable knowledge and some key considerations, e.g. regarding a number of tests, preventing combinatorial explosion and mocks in general.
Although it reads rather easily, it feels long. While reading the previous chapter, I didn't have that impression.
I guess it's mostly because of finishing up functional tests. I have a feeling the chapter could put a hard stop when we realised the first functional test passes.
Apart from that, a potentially outdated part about possible typos in mock methods caught my eye. This definitely needs consideration.