Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of decorator chapter #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Review of decorator chapter #350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions chapter_22_fixtures_and_wait_decorator.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,14 @@ servers need a way of recognising different clients with _every single request_.
IP addresses can be shared,
so the usual solution is to give each client a unique session ID,
which it will store in a cookie and submit with every request.
// DAVID: what is the 'it' in this sentence?
The server will store that ID somewhere
(by default, in the database),
and then it can recognise each request that comes in
as being from a particular client.

// DAVID: Is it worth explaining what a cookie is?

If you log in to the site using the dev server,
you can actually take a look at your session ID by hand if you like.
It's stored under the key `sessionid` by default.
Expand Down Expand Up @@ -342,7 +345,8 @@ in the `wait_to_be_logged_in/out`.
Something like this would look lovely:

// TODO: there's a change to the rows= here, backport.

// DAVID: I didn't realise that I was meant to paste this in yet -
// be more explicit?

[role="sourcecode"]
.src/functional_tests/base.py (ch20l005)
Expand Down Expand Up @@ -591,4 +595,3 @@ Avoid JSON fixtures::
((("fixtures", "JSON fixtures")))

*******************************************************************************

Loading