Temporarily support ADT and ADT matching typing in InvalML #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPTK
reviewed
May 28, 2025
Comment on lines
103
to
105
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Let's not change the whitespace.
LPTK
reviewed
Jun 9, 2025
| //│ ———————————————————————————————————————————————————————————————————————————————— | ||
|
|
||
| // * This file includes the type checking implementation for the GUI example | ||
| // * adapted from https://doi.org/10.5281/zenodo.7990289 |
There was a problem hiding this comment.
Please put such files in meaningfully-named subfolders of bbml so we can easily know what work they are ported from.
NeilKleistGao
changed the title
LPTK
reviewed
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary solution. Related code will be rewritten or removed after we truly support ADTs correctly.