Priliminary support for staged keyword
#348
Conversation
…ation during diff testing
…ring Add Block.mls into DiffMaker and prepare the function for lowering Use older Import syntax for now
|
There is no need to add such a field to |
|
You're right, I've updated the implementation to use that instead. Now I have 2 diff tests failing:
|
| val liftDefns = NullaryCommand("lift") | ||
| val importQQ = NullaryCommand("qq") | ||
| val staging = NullaryCommand("staging") | ||
| val stageCode = NullaryCommand("ds") |
There was a problem hiding this comment.
Why is the command named "ds"? I would expect this shorthand to mean "debug staging".
There was a problem hiding this comment.
It was short for "dynamic staging". Would ":staging" be a better name for the command?
| //│ rhs = N | ||
|
|
||
| // TODO: reject these annotations? | ||
| :pt |
There was a problem hiding this comment.
Please don't commit these trees. They're pure noise. Keep at most one representative :pt.
Please elaborate; this doesn't help. Why are they failing? Also, please fix the conflicts. |
Co-authored-by: Lionel Parreaux <[email protected]>
Co-authored-by: Lionel Parreaux <[email protected]>
3 participants
This is a draft PR to implement the
stagedkeyword and:stagingcompiler flag.This currently cannot merge due to the change in semantics.Import syntax in MLsCompiler.scala.
Adding the
staged: Boolfield intoFunDefnis a bit hacky to avoid rewriting existing match statements, we'll look into adding the field toClsLikeBodyinstead.